----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43377/#review118663 -----------------------------------------------------------
Looking again at this review, I really dislike that we have to include all of the patch*.xml files. However, I understand why we have them. If we ever had to change something structually, it would be a mess to try to annotate the upgrade packs. I just don't know which way to go on this. ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (line 236) <https://reviews.apache.org/r/43377/#comment179956> What is RepositoryType.SERVICE? I thought there were only going to be full and partial? - Jonathan Hurley On Feb. 9, 2016, 6:01 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43377/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 6:01 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-14978 > https://issues.apache.org/jira/browse/AMBARI-14978 > > > Repository: ambari > > > Description > ------- > > Created separate upgrade packs for patches. The necessitated a new enum > UpgradeScope to indicate that the upgrade was for partial cluster upgrades > (which will help when doing Component (Service) Upgrades). > > Also added a fix for orchestration of ClusterGroupings that target specific > services that are not getting upgraded. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 0d9176d > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > b860731 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 5e21da5 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeScope.java > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch-express.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/patch.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch-express.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/patch.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch-express.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/patch.xml > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > b15157e > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/43377/diff/ > > > Testing > ------- > > Manual. Automated: > > > Tests run: 3822, Failures: 0, Errors: 0, Skipped: 31 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:52.026s > [INFO] Finished at: Tue Feb 09 17:08:46 EST 2016 > [INFO] Final Memory: 33M/677M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
