> On Feb. 10, 2016, 10:57 p.m., Jayush Luniya wrote: > > Ship It!
Thanks Jayush & Alejandro for the review. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43423/#review118747 ----------------------------------------------------------- On Feb. 10, 2016, 11:14 p.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43423/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 11:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Oleksandr Diachenko, Richard Zang, Sumit Mohanty, Srimanth Gunturi, and > Yusaku Sako. > > > Bugs: AMBARI-14966 > https://issues.apache.org/jira/browse/AMBARI-14966 > > > Repository: ambari > > > Description > ------- > > Refer to JIRA https://issues.apache.org/jira/browse/AMBARI-14966 for images. > > Please share any concerns or questions on this minor patch as it touches the > core stack advisor. > > #Bug: > On "Assign Slave and Client page" of Add Service Wizard, slave Component (Ex: > Datanode) should not be checked on a host if its not installed on a host > > #Steps to reproduce: > 1. Install a cluster with HDFS (To start with single node host c6401) > 2. Add a new host (c6402) and don't add any of the slave components or client > 3. Add HAWQ or any other service, don't change the recommendation on master > components page and click next > 4. Datanode checkbox will be checked on c6402 even though its not installed. > > #Current Behavior: > 1. In stack advisor, a list of free hosts is created at > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L382 > 2. During the step of creating the recommendation for Slave components slave > hosts map is extended with any of the hosts in the freeHosts list at > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L412-L413 > 3. Then in Ambari-web it updates the checkbox or datanode as installed on the > free host(Ex c6402 as pert he images on JIRA). > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/stack_advisor.py d993feb > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 22b16bb > > Diff: https://reviews.apache.org/r/43423/diff/ > > > Testing > ------- > > test case added. > > > Thanks, > > bhuvnesh chaudhary > >
