----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43402/#review118777 -----------------------------------------------------------
ambari-web/app/mixins/wizard/assign_master_components.js (line 678) <https://reviews.apache.org/r/43402/#comment180090> line 680 - 682 of the original is extracted into local variables. Here, and the line 682 of patch is adding a new condition when to show master components. Is it right? - jun aoki On Feb. 10, 2016, 7:58 p.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43402/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 7:58 p.m.) > > > Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr > Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, > jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty. > > > Bugs: AMBARI-14987 > https://issues.apache.org/jira/browse/AMBARI-14987 > > > Repository: ambari > > > Description > ------- > > On the assign masters page for the wizard, recommendations are not shown for > a master component that is being added for an installed service. > > This happens while adding HAWQSTANDBY to the cluster using the 'Add > HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the > cluster). > The fix might also solve the issue where there is a installed service and the > upgrade of the service includes installing a new master component > > > Diffs > ----- > > ambari-web/app/assets/test/tests.js ecf55f7 > ambari-web/app/mixins/wizard/assign_master_components.js 0693507 > ambari-web/test/controllers/wizard/step5_test.js a2bc687 > ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION > > Diff: https://reviews.apache.org/r/43402/diff/ > > > Testing > ------- > > Manually Tested. > > Unit tests passed: > 24227 tests complete (21 seconds) > 156 tests pending > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 48.026 s > [INFO] Finished at: 2016-02-10T11:57:57-08:00 > [INFO] Final Memory: 12M/310M > [INFO] ----------------------------------------------------------------------- > > > Thanks, > > Matt > >
