> On Feb. 10, 2016, 7:15 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml, > > line 130 > > <https://reviews.apache.org/r/43421/diff/1/?file=1239383#file1239383line130> > > > > Should we also need a Ambari upgrade change to remove the extra > > property that will not be used? Its likely not a big deal as the code will > > not look at the property that is no longer used.
I did not worried much for upgrade scenario for 2 reasons: 1) As you mentioned, "the code will not look at the property that is no longer used." 2) On upgraded cluster that had this property previously, UI will no longer show this property anywhere after upgrade. This is because with the commit of this patch, property definition is removed from the stack and the property belonged to hive-env.xml file which does not have respective custom section. So even if hive config-version has this property in the API, it will not be shown anywhere in the UI. - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43421/#review118711 ----------------------------------------------------------- On Feb. 11, 2016, 3:27 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43421/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 3:27 a.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Srimanth Gunturi, and > Yusaku Sako. > > > Bugs: AMBARI-14989 > https://issues.apache.org/jira/browse/AMBARI-14989 > > > Repository: ambari > > > Description > ------- > > Hive in Ambari shows enabling CBO at two places "settings tab" and "Advanced > tab". By default both of them have same value but there is a possibility that > due to some user actions, values at these two places may differ and create > confusion. > > There seems to be additional ambari maintained property for CBO which should > not be needed as hive inherently has this property in hve-site.xml. > The submitted patch removes ambari maintained property which was shown in > Advanced hive-env section. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml > f84bc01 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > cc3e75f > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 9be6410 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-env.xml > 3d1b549 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml > 7e13436 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > c6941f0 > > ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json > 7829f05 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 904688a > ambari-server/src/test/python/stacks/2.3/common/services-sparkts-hive.json > 51ae36a > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 79f4f79 > > Diff: https://reviews.apache.org/r/43421/diff/ > > > Testing > ------- > > Verified manually on the cluster > Verified on branch-2.2 that all ambari-server python tests passes > successfully: > ---------------------------------------------------------------------- > Ran 242 tests in 7.231s > OK > ---------------------------------------------------------------------- > Total run:881 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jaimin Jetly > >
