----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43428/#review118864 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java (lines 111 - 112) <https://reviews.apache.org/r/43428/#comment180173> Column declaration doesn't match SQL. You should add the `NOT NULL DEFAULT 1`. ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (lines 1062 - 1075) <https://reviews.apache.org/r/43428/#comment180174> Any reason these are not in the order according to the sort? I know it makes no difference, but visually it would be easier to see if there were errors. ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql (line 525) <https://reviews.apache.org/r/43428/#comment180175> I believe that Oracle syntax requires the `DEFAULT` to be before the `NOT NULL` - Jonathan Hurley On Feb. 10, 2016, 2:23 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43428/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 2:23 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Nettleton. > > > Bugs: AMBARI-14980 > https://issues.apache.org/jira/browse/AMBARI-14980 > > > Repository: ambari > > > Description > ------- > > Since it may be desired to order roles in ways other than alphabetically, > each role should have an explicit numerical order that may be used by UI's. > > Roles should be explicitly ordered by the amount of access privileges they > have. > > > Role Name | Explicit Order Value > ----------------------|---------------------- > Ambari Administrator | 1 > Cluster Administrator | 2 > Cluster Operator | 3 > Service Administrator | 4 > Service Operator | 5 > Cluster User | 6 > View User | 7 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java > 640123e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java > a692730 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3414388 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0fdfd2b > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 11e43c2 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8d4ba28 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c762ac4 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 81b41fe > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql f8c9b8d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 324c24d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java > 7658c0f > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > d1d68f2 > > Diff: https://reviews.apache.org/r/43428/diff/ > > > Testing > ------- > > Manualy tested a new install and an upgrade > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:03:22.906s > [INFO] Finished at: Wed Feb 10 14:03:26 EST 2016 > [INFO] Final Memory: 68M/1507M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test result: PENDING > > > Thanks, > > Robert Levas > >
