----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43248/#review119011 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Feb. 12, 2016, 4:13 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43248/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2016, 4:13 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-14936 > https://issues.apache.org/jira/browse/AMBARI-14936 > > > Repository: ambari > > > Description > ------- > > 1\. Don't build common-services and stacks folder into ambari-server.jar. This > reduces jar size from 20Mb to 7Mb. And also reduces its buildtime. > 2\. -DassemblyPhase=none option to skip building tarballs. Is useful when > building simply a jar is needed. > 3\. -Dnodemodules.dir option to not redownload node_modules folder in ambari- > web. This reduces ambari-web time from ~1.1 min. to ~15s. (unless it's a first > build and node_modules is not there). However this may rearly result in npm > cache issues, which is simply solved by 'rm -rf ambari-web/node_modules' > > > Diffs > ----- > > ambari-agent/pom.xml bb7cc34 > ambari-server/pom.xml 33b5501 > ambari-web/pom.xml 761a3f0 > pom.xml 57c6de7 > > Diff: https://reviews.apache.org/r/43248/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
