-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43528/#review119048
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 (line 287)
<https://reviews.apache.org/r/43528/#comment180327>

    I think value can be 512m as well as 512, but I'm not sure


- Dmytro Sen


On Фев. 12, 2016, 5:29 п.п., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43528/
> -----------------------------------------------------------
> 
> (Updated Фев. 12, 2016, 5:29 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15030
>     https://issues.apache.org/jira/browse/AMBARI-15030
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Default values from the stack (Not stack advisor)
> regionserver_heapsize : 512MB
> regionserver_xmn_size : 256MB
> 
> xmn is 50% of rs heapsize which is unreasonable. Changing to 756MB and 128MB 
> respectively.
> 
> Made the changes in stack_Advisor and UpgradeCatalog too.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  88b3151 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  191e8b2 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> af21008 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  6061e06 
> 
> Diff: https://reviews.apache.org/r/43528/diff/
> 
> 
> Testing
> -------
> 
> UpgradeCatalog tests pass.
> Python unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to