> On Feb. 13, 2016, 5:26 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2258 > > <https://reviews.apache.org/r/43559/diff/1/?file=1241159#file1241159line2258> > > > > QQ: The updater handles NN HA properly ?
Blueprint expects users to put in the value of name-service if its a NN-HA cluster. So in that case users will specify "mapreduce.job.hdfs-servers":"nnha" and the code will not update the property value. It only updates if it finds pattern such as "%HOSTGROUP::headnode0%" - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43559/#review119150 ----------------------------------------------------------- On Feb. 13, 2016, 4:43 p.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43559/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2016, 4:43 p.m.) > > > Review request for Ambari, Mahadev Konar, Robert Nettleton, and Sid Wagle. > > > Bugs: AMBARI-15035 > https://issues.apache.org/jira/browse/AMBARI-15035 > > > Repository: ambari > > > Description > ------- > > drpc.servers is a property in storm yaml config file that captures the drpc > server hostname. During blueprint based deployments this can be specified by > the user but some code changes are needed to have the blueprint config > processor resolve the value to actual hostname. > > mapreduce.job.hdfs-servers support need to be added to resolve to NN host. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 7fb2592 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 9c76e8a > > Diff: https://reviews.apache.org/r/43559/diff/ > > > Testing > ------- > > Tested manually and added unit tests for these two new properties. > > > Thanks, > > Sumit Mohanty > >
