-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43581/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-15050
    https://issues.apache.org/jira/browse/AMBARI-15050


Repository: ambari


Description
-------

- Decouple from yarn-site the security knobs that control https support. 
(Nothing special here except read it from ams-site).
- Expect all cert configs to be specified like keystore path etc.
- Setup for cert / keystore is all manual similar to hadoop.
- Test e2e that https works.


Diffs
-----

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 9173889 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/conf/flume-metrics2.properties.j2
 bc18043 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 cf2b4ae 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/conf/hadoop-metrics2-hbase.properties.j2
 0d13498 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/conf/hadoop-metrics2.properties.j2
 76a00d1 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 000b82e 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 6b23f36 
  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
d302518 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 48f5af2 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
6f66093 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
 4915435 
  
ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java
 6f2fc27 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 f054f16 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 4208287 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
 11c162a 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/net/RestMetricsSender.java
 c6d84c2 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 cc9a2f3 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/ComponentSSLConfiguration.java
 a51b2ee 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 35e9b6f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java
 c62b00c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProvider.java
 e8dc7d1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 3ecb520 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
 e40a5a5 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml
 f40da62 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 c415f6e 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
 399e0c9 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 180b43b 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-client.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 67a93a5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 40188c2 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 5ab40b0 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 8193737 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 f19c823 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 a65ea88 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 fc86a58 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml 
5e5e4a7 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 d2f2d02 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
 753aa3f 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
ce625eb 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml 
78aca3d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 337f09d 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
 f74ea4c 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 2df141f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
73616ae 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-broker.xml
 6d0c8c6 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metainfo.xml 
66286b3 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py
 1c01174 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
 da76952 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml 
1468a2f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 f186a89 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2
 01c61bf 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2
 a5ee7a9 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
969c2a7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 426237c 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
 8e729a4 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ComponentSSLConfigurationTest.java
 58bc47e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java
 b513ba5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaReportPropertyProviderTest.java
 0f01b24 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
 1394081 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java
 1a3afbc 
  
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
 1c83bb7 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json cb34098 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
0ce8e5a 

Diff: https://reviews.apache.org/r/43581/diff/


Testing
-------

Unit tests passed.


Thanks,

Dmytro Sen

Reply via email to