----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43551/#review119344 -----------------------------------------------------------
Ship it! Ship It! - Richard Zang On Feb. 13, 2016, 12:20 a.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43551/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2016, 12:20 a.m.) > > > Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15038 > https://issues.apache.org/jira/browse/AMBARI-15038 > > > Repository: ambari > > > Description > ------- > > In alert definitions, percentage params (e.g. NameNode RPC Latency (Daily) > --> standard deviation threshold) get validation errors when their values are > above 100, which could be a valid value. > Resolution is removing the restriction of value has to be less than 100. > > > Diffs > ----- > > ambari-web/app/models/alerts/alert_config.js c86b19a > ambari-web/test/models/alerts/alert_config_test.js 4b788f8 > > Diff: https://reviews.apache.org/r/43551/diff/ > > > Testing > ------- > > Modified unit test. Local ambari-web test passed. > 24292 tests complete (21 seconds) > 156 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
