> On Feb. 16, 2016, 1:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java, > > line 153 > > <https://reviews.apache.org/r/43605/diff/1/?file=1251802#file1251802line153> > > > > m_id.hashCode() ? I've come to find ObjectUtils.hashCode(Object) is a > > nice alternative
How dare you challenge the old-school bit shifting of Eclipse! I'll change it; nice util. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43605/#review119342 ----------------------------------------------------------- On Feb. 16, 2016, 10:56 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43605/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 10:56 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-15058 > https://issues.apache.org/jira/browse/AMBARI-15058 > > > Repository: ambari > > > Description > ------- > > Create schema and entities to manage upgrade and downgrade history for > components. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java > b8c2fcc > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > d2d1b42 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java > PRE-CREATION > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 6c94999 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7f5eddc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e3e4336 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f5983a5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 9d9a986 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8c82afc > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e36519e > ambari-server/src/main/resources/META-INF/persistence.xml 7fd0391 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 4e8713b > > Diff: https://reviews.apache.org/r/43605/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
