----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42838/#review119385 -----------------------------------------------------------
Ship it! General comment: It is cleaner to work with entities than issuing direct SQL. - Sid Wagle On Feb. 16, 2016, 11:36 p.m., Ajit Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42838/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 11:36 p.m.) > > > Review request for Ambari, Jayush Luniya, Nahappan Somasundaram, and Sumit > Mohanty. > > > Bugs: AMBARI-14912 > https://issues.apache.org/jira/browse/AMBARI-14912 > > > Repository: ambari > > > Description > ------- > > Update upgrade catalog 240 and add db schema changes for settings table. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3414388b9a738a4fc7cc5d0f484fe553cce840ee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > d1d68f24871422936321ad0c940499fc1ef4cbec > > Diff: https://reviews.apache.org/r/42838/diff/ > > > Testing > ------- > > ran ambari-server upgrade maually and checked impacted db tables to make sure > correct entry is present. > > > After successfully upgrade, updated metainfo table with old version and ran > ambari-server upgrade and it was successful. > > > Thanks, > > Ajit Kumar > >
