----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review119518 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh (line 21) <https://reviews.apache.org/r/43663/#comment180874> Why are the table names hardcoded here and not used from the variable in pxf-constants? ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 243) <https://reviews.apache.org/r/43663/#comment180875> Is it required to write these files everytime service check is executed? Why not just use the existing file from package/files/ directory, rather than write it to Agents temp directory and then use it again? ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 298) <https://reviews.apache.org/r/43663/#comment180873> May be str(hive_load_commands) ? - Matt On Feb. 17, 2016, 11:06 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43663/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 11:06 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Oleksandr Diachenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-15061 > https://issues.apache.org/jira/browse/AMBARI-15061 > > > Repository: ambari > > > Description > ------- > > During PXF service check, in order to execute hbase / hive command, we do > initialize the shell everytime (hbase shell / hive) and then run the command. > Initializing the shell takes time and we do that around 3-4 times which > consumes majority of the time. > We should initialize the shell once, and execute the commands using a file > instead of doing individually. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > b3e85e4 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py > 9d93a38 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py > 21b7c5d > > Diff: https://reviews.apache.org/r/43663/diff/ > > > Testing > ------- > > yes. manual. > > > Thanks, > > bhuvnesh chaudhary > >
