----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43729/#review119900 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 149) <https://reviews.apache.org/r/43729/#comment181291> Typo, missing a space before the "(" ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 172) <https://reviews.apache.org/r/43729/#comment181292> To improve readability, use spaces after "," ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 187) <https://reviews.apache.org/r/43729/#comment181293> Can use the parametrized LOG.level with "{}" instead of String.format ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java (line 224) <https://reviews.apache.org/r/43729/#comment181294> Typo, insert space before "(" - Alejandro Fernandez On Feb. 19, 2016, 5:26 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43729/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 5:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-15095 > https://issues.apache.org/jira/browse/AMBARI-15095 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java > 0396767 > > ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java > 67594b7 > > Diff: https://reviews.apache.org/r/43729/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
