> On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 1590 > > <https://reviews.apache.org/r/43425/diff/9/?file=1264370#file1264370line1590> > > > > Does this now need to be transacitonal since it's affecting multiple > > entities? Hard to tell from ReviewBoard if a method invocation this one > > already has started a transaction.
I think no > On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 171 > > <https://reviews.apache.org/r/43425/diff/8-9/?file=1259340#file1259340line171> > > > > Oracle needs `DEFAULT` before `NOT NULL` You are right, missed that > On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql, > > line 784 > > <https://reviews.apache.org/r/43425/diff/8-9/?file=1259342#file1259342line784> > > > > This won't work unless the `upgrade` table is declared before this > > statement, which it's not. > > > > Also, I don't see this FK relationship in the other SQL files. Thanks, good catch. Moved table creations higher Regarding FK relationship - in other files, it looks like ALTER TABLE clusters ADD CONSTRAINT FK_clusters_upgrade_id FOREIGN KEY (upgrade_id) REFERENCES upgrade (upgrade_id); > On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java, > > lines 107-109 > > <https://reviews.apache.org/r/43425/diff/9/?file=1264374#file1264374line107> > > > > Let's add a comment as to why this is required; since none of the > > entities for the request are actually persisted yet, JPA ordering could > > allow foreign key entities to be created after this statement. done - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43425/#review120174 ----------------------------------------------------------- On Feb. 22, 2016, 8:46 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43425/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 8:46 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-14996 > https://issues.apache.org/jira/browse/AMBARI-14996 > > > Repository: ambari > > > Description > ------- > > When performing an upgrade, we need to specify that a component's desired > version is getting changed. Also upgrade status is tracked based on component > statuses (not host/cluster versions) > > > Diffs > ----- > > .gitignore a8c4aab > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 248ce4b > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > b62f4d1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 87731c4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 860ba88 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java > ee65d3d > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 74d4f4b > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java > 3a11f38 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java > 06f6ac1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java > 2c4d695 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > f92f645 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java > 519e4e6 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 03d407a > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 360f2b8 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > b430525 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > 344f358 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > dcb7cf6 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > f1e8d62 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > eca911d > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 5143bfa > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java > ced1dd3 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 07addfc > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 92828af > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java > 1c36143 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > c032b8f > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1 > > ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java > 0e9b18d > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 2a4cec8 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 9c59cde > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 992150c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > 9b27447 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java > b0e3467 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 035c61a > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > ad53f70 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 772d68a > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java > ae05a6b > > ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java > 071c6f0 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 71b89c3 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > b57db5b > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > e8e5d20 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java > 3ad2240 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java > 89f0ba6 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > 14137cc > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 989eba2 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > 55e7a61 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 62d5981 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java > 847de7d > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 2ffcd5d > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java > 7cb7679 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > daf8d12 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java > 4845d6f > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java > 81399a1 > > ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java > 4248d13 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 62f2cbf > > Diff: https://reviews.apache.org/r/43425/diff/ > > > Testing > ------- > > EU/RU seems to work > Unit tests pass with ignored failing tests (will create a jira) > > > Thanks, > > Dmitro Lisnichenko > >
