> On Feb. 25, 2016, 1:36 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py, > > line 257 > > <https://reviews.apache.org/r/43948/diff/2/?file=1270961#file1270961line257> > > > > Can we change it to this: > > > > if HdfsResourceProvider.parse_path(dir_path) in ignored_dfs_dirs: > > > > > > In this case different spellings of the same folder will be matched > > > > like > > > > /a/b/c > > //a/b/c > > hdfs:///a/b/c > > hdfs://nn1:8020/a/b/c > > Sebastian Toader wrote: > It's already there: see line 252
Yep, my bad. +1 - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43948/#review120695 ----------------------------------------------------------- On Feb. 25, 2016, 1:14 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43948/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 1:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15158 > https://issues.apache.org/jira/browse/AMBARI-15158 > > > Repository: ambari > > > Description > ------- > > If ATS is installed than Resource Manager after starting will check if the > directories where ATS will store time line data for active and completed > applications exists in DFS. There migh tbe cases when RM comes up much > earlier than ATS creating these directories. In these situations RM will stop > with "IOException: /ats/active does not exist" error message. > > In order to avoid this situation the pythin script responsible for starting > RM component has been modified to check the existence of these directories > upfront before the RM process is started. This check is performed only if ATS > is installed and have either > yarn.timeline-service.entity-group-fs-store.active-dir or > yarn.timeline-service.entity-group-fs-store.done-dir set. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > b73ae56 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 2ef404d > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py > ec7799e > > Diff: https://reviews.apache.org/r/43948/diff/ > > > Testing > ------- > > Manual testing: > 1. Created secure/non-secure clusters with Blueprint where NN, RM and ATS > were deployed to different nodes. This was tested with both cases when HDFS > has webhdfs enabled and disabled. > 2. Created a cluster using the UI where NN, RM and ATS were deployed to > different nodes. After the cluster was kerberized and was tested with both > cases when HDFS has webhdfs enabled and disabled. > > Python tests results: > ---------------------------------------------------------------------- > Total run:902 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sebastian Toader > >
