> On Feb. 26, 2016, 5:26 a.m., Matt wrote: > > ambari-web/app/models/stack_service.js, line 402 > > <https://reviews.apache.org/r/44055/diff/1/?file=1271824#file1271824line402> > > > > May I know why the pxf config filenames ended up here, but the HAWQ > > config files have an additional attribute (as in trunk)? > > > > Curious why it worked for HAWQ but not PXF...
Good point. PXF does not have -env at the end of the files added up here. And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for them in the *xml. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44055/#review120830 ----------------------------------------------------------- On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44055/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 6:11 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, > Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-15175 > https://issues.apache.org/jira/browse/AMBARI-15175 > > > Repository: ambari > > > Description > ------- > > This minor patch hides custom configuration category for files which does not > support custom configuration in HAWQ and PXF > > > Diffs > ----- > > ambari-web/app/models/stack_service.js d9edf6e > > Diff: https://reviews.apache.org/r/44055/diff/ > > > Testing > ------- > > yes. manual. > > > Thanks, > > bhuvnesh chaudhary > >
