-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44109/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and
Sumit Mohanty.
Bugs: AMBARI-15213
https://issues.apache.org/jira/browse/AMBARI-15213
Repository: ambari
Description
-------
* RBAC : Background Jobs window doesn't show when login user role is :
CLUSTER.ADMINISTRATOR, SERVICE.OPERATOR, SERVICE.ADMINISTRATOR and
CLUSTER.OPERATOR.
* Currently, background Jobs window only comes for AMBARI.ADMINISTRATOR.
*
*
* Reason : It happenning because the UI calls for
api/v1/persist/admin-settings-show-bg-<username> and BE returns 404, because
the persistence of user values is not allowed other than Ambari Adminsistrator.
*
* Change :
Backend : Created a new Authroization "CLUSTER.MANAGE_USER_PERSISTED_DATA"
which can be imparted to the roles CLUSTER.ADMINISTRATOR,
SERVICE.OPERATOR, SERVICE.ADMINISTRATOR, CLUSTER.OPERATOR and
AMBARI.ADMINISTRATOR.
Frontend : Earlier it was check authorization :
CLUSTER.UPGRADE_DOWNGRADE_STACK (misnomer) to use
CLUSTER.MANAGE_USER_PERSISTED_DATA.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java
4db5611
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
e2a28d0
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
a77263d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
2f509b4
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9c61cbc
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0ebfa40
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql a8cbda3
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
8ce2ba8
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b7a764e
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f60f07a
ambari-web/app/mixins/common/userPref.js 5a531f2
Diff: https://reviews.apache.org/r/44109/diff/
Testing
-------
- Manual Testing : Tested the behavior for all the roles. Works.
- Upgrade from 2.3 to 2.4 : Works.
-
- Unit tests : Submitted the patch for full testing. Will update the results.
Thanks,
Swapan Shridhar
