----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44167/#review121286 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Feb. 29, 2016, 8:09 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44167/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 8:09 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-15222 > https://issues.apache.org/jira/browse/AMBARI-15222 > > > Repository: ambari > > > Description > ------- > > The config-changes.xml files are in the wrong spots. The config changes for > 2.2 -> 2.3 are in the 2.3 directory. They should be in the 2.2 directory > since those are used to go FROM 2.2 TO 2.3. We have to be consistent with > where the changes match the upgrade packs. > > NOTE: I think now it's a good time to get this change in, because older > branches are being released and not actively developed, and newer upgrade > packs are not added yet. I'm going to send a notification to group once > that's in. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 08665dd > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > ffc7ffb > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 2f042b1 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > 1cc2668 > > Diff: https://reviews.apache.org/r/44167/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
