----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44174/#review121292 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py (line 36) <https://reviews.apache.org/r/44174/#comment182976> Do we also need to remove any whitespace after splitting? ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java (line 346) <https://reviews.apache.org/r/44174/#comment182977> We need to ensure this property exists during RU/EU. - Alejandro Fernandez On Feb. 29, 2016, 6:39 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44174/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 6:39 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-15228 > https://issues.apache.org/jira/browse/AMBARI-15228 > > > Repository: ambari > > > Description > ------- > > Ambari is overriding permissions on default HDFS directories such as /app- > logs, /apps/hive/warehouse, /tmp. > This is allowing any user to write in those locations preventing them from > having control via Ranger/HDFS > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > ed9a642 > > ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py > 06d0f2b > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 46151bd > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 2335f74 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 157b961 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 43aba04 > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > bc90a8c > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > 09af8a9 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 3bd98a2 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > 5f942f6 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 6c8d5ff > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 7564905 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 7633731 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 4052f83 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > 34bb032 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > d61dc2e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > bcfa4f3 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 6ec3996 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 078900e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > e25a9a0 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc46749 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 9d4847f > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py > b261b23 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > b7ee0be > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py > 17998c6 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > 1dbed45 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py > 132ff77 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py > 52c78c5 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 94988ce > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py > f0ba617 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > f30b807 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml > 59d4964 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 8d7427d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > a939302 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml > b444c11 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 64094c0 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml > 3059db6 > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java > d774ab8 > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java > 291a2d9 > > Diff: https://reviews.apache.org/r/44174/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
