> On Feb. 27, 2016, 12:45 a.m., Goutam Tadi wrote: > > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, > > line 28 > > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line28> > > > > Can we use like the one following > > ``` > > COMMON_SERVICES_PACKAGE_DIR = "PXF/3.0.0/package" > > ``` > > > > in ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py
I am kind of mimicing this https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py#L33 but use a bunch of ".." instead of a bunch of dirname methods. - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44119/#review121020 ----------------------------------------------------------- On Feb. 27, 2016, 12:35 a.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44119/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 12:35 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15211 > https://issues.apache.org/jira/browse/AMBARI-15211 > > > Repository: ambari > > > Description > ------- > > Add alerts for PXF availability. > The availability could be same as its service check. (by hitting the version > api) > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/44119/diff/ > > > Testing > ------- > > Manually tested. > > > ---------------------------------------------------------------------- > Ran 275 tests in 6.876s > > OK > ---------------------------------------------------------------------- > Total run:924 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > jun aoki > >
