----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44119/#review121376 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 88) <https://reviews.apache.org/r/44119/#comment183046> +1 for using Fail instead of Exception. Some of try-except blocks might be expection type Fail, not Exception and exception wouldn't be handled propertly. ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 106) <https://reviews.apache.org/r/44119/#comment183050> Extra space and colon needed? ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 121) <https://reviews.apache.org/r/44119/#comment183047> Better to raise Fail. ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 127) <https://reviews.apache.org/r/44119/#comment183048> There is JIRA in current trunk, which changed version response to this format: { "version": "v14"} https://issues.apache.org/jira/browse/HAWQ-340 So patch for trunk might be expect new response format. ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py (line 26) <https://reviews.apache.org/r/44119/#comment183049> Are we using all files which we are importing? If no, I would explicitly import whatever you need only. - Oleksandr Diachenko On Feb. 29, 2016, 11:50 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44119/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 11:50 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-15211 > https://issues.apache.org/jira/browse/AMBARI-15211 > > > Repository: ambari > > > Description > ------- > > Add alerts for PXF availability. > The availability could be same as its service check. (by hitting the version > api) > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/44119/diff/ > > > Testing > ------- > > Manually tested. > > > ---------------------------------------------------------------------- > Ran 275 tests in 6.876s > > OK > ---------------------------------------------------------------------- > Total run:924 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > jun aoki > >
