----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44188/#review121465 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java (line 124) <https://reviews.apache.org/r/44188/#comment183175> Probably not queried often, but can't this data be cached after first retrieval? It can't change in the running VM, can it? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java (lines 171 - 173) <https://reviews.apache.org/r/44188/#comment183174> Log it at least? You know that in 2 years, this will be throwing an exception and it'll take you a whole day to figure out what's wrong :) - Jonathan Hurley On March 1, 2016, 11:26 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44188/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 11:26 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, and > Yusaku Sako. > > > Bugs: AMBARI-15232 > https://issues.apache.org/jira/browse/AMBARI-15232 > > > Repository: ambari > > > Description > ------- > > Provide details on the JCE policy installed in the JVM used by Ambari. This > data should be retrievable when querying the REST API > > #`GET /api/v1/services/AMBARI/components/AMBARI_SERVER` > ``` > ... > "jce_policy" : { > "unlimited_key": "true", > ... > }, > "ciphers" : { > ... > } > ... > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java > 0f16966 > ambari-server/src/main/resources/properties.json 01c15f2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java > 1b742af > > Diff: https://reviews.apache.org/r/44188/diff/ > > > Testing > ------- > > Manually tested > > # Jenkins test results: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:34 h > [INFO] Finished at: 2016-03-01T08:00:41+00:00 > [INFO] Final Memory: 139M/508M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
