> On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, > > line 146 > > <https://reviews.apache.org/r/43830/diff/2/?file=1275135#file1275135line146> > > > > Is this the version currently on? > > We need to ensure that this is idempotent.
It gives the stack version to upgrade(destination version) to, if an upgrade is currently in progress and is fixed. > On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 51 > > <https://reviews.apache.org/r/43830/diff/2/?file=1275137#file1275137line51> > > > > stack_version should be a required param without a default value This is not required since it is handled like this: version = params.version if stack_version is not None: kms_home = format("/usr/hdp/{stack_version}/ranger-kms") version = stack_version > On March 1, 2016, 6:22 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, > > line 126 > > <https://reviews.apache.org/r/43830/diff/2/?file=1275137#file1275137line126> > > > > This method doesn't actually accept stack_version but the caller in the > > file above passes it. We have same named function for Ranger and Ranger KMS. `setup_java_patch` function in Ranger file `setup_ranger_xml.py` accepts the parameter stack_version, while the one in kms does not. - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43830/#review121457 ----------------------------------------------------------- On March 1, 2016, 2 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43830/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 2 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan > Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: AMBARI-15127 > https://issues.apache.org/jira/browse/AMBARI-15127 > > > Repository: ambari > > > Description > ------- > > Need to apply multiple retries for Ranger DB setup calls to handle concurrent > calls to one DB from 2 different hosts where Ranger Admin is installed. > This scenario is needed to handle upgrades of HDP in a case when Ranger HA is > enabled. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 5bcf6b9 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > fcceaa6 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 7c7a7c8 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > 4ffc8eb > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 4b5b8d5 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 50a9848 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 8003ee0 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > f775314 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > b09c84a > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > 5bc360e > > Diff: https://reviews.apache.org/r/43830/diff/ > > > Testing > ------- > > Installed Ranger on Debian 7 + Ranger HA and then performed EU to 2.4.0.0-XXX. > > > Thanks, > > Gautam Borad > >
