> On March 2, 2016, 2:17 p.m., Jonathan Hurley wrote: > > Can you explain how this fixes the problem? It looks like you're just > > ensuring that the stack listener sets the upgrade state to NONE. The > > problem reported was that, when upgrading, we were getting a warning on > > ZKFC b/c current != desired (both were UNKNOWN). > > > > I just want to make sure the problem reported is being fixed.
You are referring just a diagnostic output, that is valid. The original problem is that ZKFC got into VERSION_MISMATCH state (pre-upgrade check verifies only that). VERSION_MISMATCH is not a valid state for ZKFC, and current patch fixes the place where ZKFC transitioned to this state. That occurs when heartbeat reports no version, we missed isVersionAdvertised() check here. Patch has been verified to fix the problem - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44264/#review121626 ----------------------------------------------------------- On March 2, 2016, 1:55 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44264/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 1:55 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-15260 > https://issues.apache.org/jira/browse/AMBARI-15260 > > > Repository: ambari > > > Description > ------- > > When preparing to upgrade stack versions, the following warning is seen: > > {code} > Reason: c6401.ambari.apache.org/ZKFC desired version: UNKNOWN, actual > version: UNKNOWN > c6402.ambari.apache.org/ZKFC desired version: UNKNOWN, actual version: UNKNOWN > Failed on: c6401.ambari.apache.org,c6402.ambari.apache.org > {code} > > We should be excluding non-versioned components from this check. Not sure > which branches this might exist in; I encountered this in trunk. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 9d989f1 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java > aa405ae > > Diff: https://reviews.apache.org/r/44264/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
