----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44253/#review121715 -----------------------------------------------------------
Tested the feature with stack upgrade: - Installed HDP 2.3 stack - Added entry for custom service repo to 2.3 repoinfo.xml, used the 'Add Repo' feature on UI to add the repo to 2.3 stack and installed the custom service - Upgraded to HDP 2.4 stack - The custom service repo is not carried over from 2.3 to 2.4 (I think this is the intended behavior as it should not carry over repos from old repos to new repos) Some possible thoughts/enhancements for the future: - Skip the part where the user has to add to repoinfo.xml before adding it to the UI? (Will have to investigate the impact on current behavior) - When stack is upgraded, what should happen to the custom service repos? Should there be an option during upgrade to carry over this repo to the new stack? - Matt On March 2, 2016, 11:41 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44253/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 11:41 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-13216 > https://issues.apache.org/jira/browse/AMBARI-13216 > > > Repository: ambari > > > Description > ------- > > This patch adds a UI button to the Ambari Admin view which allows users to > Add a repository to an stack which is already installed on the cluster. > > Steps to follow to add a new repository to the stack: > - Add the new repository to HDP/x.y/repos/repoinfo.xml > - Check if the new repository is available at the REST endpoint. Eg: > http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.4/operating_systems/redhat6/repositories > - Go to Ambari Admin UI and add the repository. > > **Screenshots:** > > >  > > >  > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/index.html fe049ac > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 97a7696 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > dcd79df > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddRepositoryModal.js > PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css ff963ee > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddRepositoryModal.html > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > 0c6ca84 > > Diff: https://reviews.apache.org/r/44253/diff/ > > > Testing > ------- > > Manually Tested. > > > Thanks, > > Matt > >
