> On March 2, 2016, 8:56 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java, > > line 109 > > <https://reviews.apache.org/r/44276/diff/1/?file=1277665#file1277665line109> > > > > Seems ts is already present in constructor
This is required because we do not want to use the timestamp read from the db for the Aggregated metric record. > On March 2, 2016, 8:56 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricClusterAggregator.java, > > line 75 > > <https://reviews.apache.org/r/44276/diff/1/?file=1277667#file1277667line75> > > > > Shouldn't max of server time be alligned alredy, I think this might > > introduce test skew if there is any faulty login in aggregations. This is required because we do not want to use the timestamp read from the db for the Aggregated metric record in the aggregation of METRIC_RECORD rows into METRIC_RECORD_MINUTE. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44276/#review121709 ----------------------------------------------------------- On March 2, 2016, 6:27 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44276/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 6:27 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15267 > https://issues.apache.org/jira/browse/AMBARI-15267 > > > Repository: ambari > > > Description > ------- > > The timestamp of aggregated metrics is tied to service start time. For > example if the AMS service was started at 10:21, all hourly aggregated metric > will have timestamps like 10:21, 11:21, 12:21 and so on. > If AMS was restarted at 1:47, the subsequent hourly aggregates will have > timestamps like 1:47, 2:47, 3:47 and so on. > > This creates inconsistency and difficulty in using the metrics. All aggregate > timestamps should have definitive boundaries. For example, irrespective of > when the AMS was started, the hourly aggregate should always be timestamped > to top of hour (eg. all aggregated metrics having timestamp >= 10 AM and < > 11:00 AM should be timestamped to 11:00 AM ), and similarly 5 minute > aggregates should be timestamped to 0th, 5th, 10th, 15th..... minute > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 37e4796 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java > fce5a39 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineClusterMetric.java > 3c30a6f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAggregatorFactory.java > cc85c56 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java > 1c1c4b6 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricHostAggregator.java > e0fa26e > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricClusterAggregator.java > 5257412 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricHostAggregator.java > 1c46642 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 2fc6c34 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java > e3e037a > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregatorTest.java > 2b29469 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java > f201224 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITMetricAggregator.java > 9c7c8fa > > Diff: https://reviews.apache.org/r/44276/diff/ > > > Testing > ------- > > Manually tested different scenarios. > > Added unit tests. > > ambari-metrics unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
