-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44373/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-15293
https://issues.apache.org/jira/browse/AMBARI-15293
Repository: ambari
Description
-------
For rpc metrics the port number determines what rpc calls are being tracked.
_Example_: Namenode can have different rpc ports for Datanode and clients and
healthchecks. Presently since the port number is not a part of the metricsName
the two metric entries will step on each other in AMS store.
This patch only addresses the fix for HDFS.
Diffs
-----
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
b2810b7
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
6da9257
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
528384e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java
3dbe0a8
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
c1b9c50
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
cefe953
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
b8d47f9
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json
7e93a6e
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
dc71408
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
f9c2164
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java
f4c212c
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java
d450177
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
5445b32
Diff: https://reviews.apache.org/r/44373/diff/
Testing
-------
Manaully ran affected unit tests.
Manually tested all individual parts affected.
----------------------------------------------------------------------
Ran 244 tests in 7.160s
OK
----------------------------------------------------------------------
Total run:893
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
