----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42032/#review122099 -----------------------------------------------------------
I am not particularly keen on _faking_ hostnames like this since it may have security-related implications. Such as SSL certificate validation and Kerberos princial generation. Since I am not a network person, I am not sure if the routing issue you are trying to solve can be solved via network configuration rather than DNS - which I think would be preferred. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (line 302) <https://reviews.apache.org/r/42032/#comment184007> This probably does not compile since `getApiHostname()` returns a `String` and the `if` clause is looking for a `boolean` value. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (lines 302 - 307) <https://reviews.apache.org/r/42032/#comment184008> The result of this should be logged as `INFO` so that when problems occurr we can know what the cluster is using as the `masterHostname` when looking at the logs. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (line 324) <https://reviews.apache.org/r/42032/#comment184009> The result of this should be logged as `INFO` so that when problems occurr we can know what the cluster is using as the `masterHostname` when looking at the logs. - Robert Levas On Jan. 7, 2016, 3:23 p.m., Greg Hill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42032/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 3:23 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-12916 > https://issues.apache.org/jira/browse/AMBARI-12916 > > > Repository: ambari > > > Description > ------- > > This lets you configure the hostname that the Ambari server passes to the > views and agent so you can specify it differently from the system hostname. > This is useful in cases where you want to use a fqdn for API access but a > local hostname for local cluster communication. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 371d5d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a7f206a > > Diff: https://reviews.apache.org/r/42032/diff/ > > > Testing > ------- > > Honestly, not much. There weren't any existing unit tests for the code I > modified and I'm not a Java developer so I didn't really know where to start > with creating them. It's a pretty simple change and doesn't break any > existing tests, but I'm happy to do some more testing if someone can provide > some direction. > > > Thanks, > > Greg Hill > >
