----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44375/#review122164 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml (line 153) <https://reviews.apache.org/r/44375/#comment184062> Could we have <description> ? ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml (line 249) <https://reviews.apache.org/r/44375/#comment184065> Trivial, but HAWQ users are so used to talk about "vm.overcommit_memory", and they may Ctrl-F or search that exact keyword, instead of "VM Overcommit". Did you want to add "aka vm.overcommit_memory" in somewhere? It could be in <description> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml (line 153) <https://reviews.apache.org/r/44375/#comment184064> trivial but indentation seems off. ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml (line 203) <https://reviews.apache.org/r/44375/#comment184061> Could we have <description> ? - jun aoki On March 4, 2016, 2:05 a.m., Matt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44375/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 2:05 a.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Lav Jain, and Newton Alex. > > > Bugs: AMBARI-15107 > https://issues.apache.org/jira/browse/AMBARI-15107 > > > Repository: ambari > > > Description > ------- > > Add theme for HAWQ > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml > 58bfa27 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml > d8917e6 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 457c1d2 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > 32ae5a5 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml > 053f108 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml > a2296a1 > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml > a772839 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/44375/diff/ > > > Testing > ------- > > Manully Tested on live cluster. > > > Thanks, > > Matt > >
