----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44413/#review122214 -----------------------------------------------------------
ambari-web/app/controllers/main/host/bulk_operations_controller.js (line 323) <https://reviews.apache.org/r/44413/#comment184123> You may use Ember's filter function here. ambari-web/app/controllers/main/host/bulk_operations_controller.js (line 324) <https://reviews.apache.org/r/44413/#comment184122> You may use Ember [.filter](http://emberjs.com/api/classes/Ember.Array.html#method_filter) ```javascript var hostsWithOutComponent = hosts.filter(function(host) {return !hostsWithComponent.contains(host);}); ``` - Matt On March 4, 2016, 6:07 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44413/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 6:07 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15308 > https://issues.apache.org/jira/browse/AMBARI-15308 > > > Repository: ambari > > > Description > ------- > > On Hosts page, provide ability to add host components in bulk. > These bulk operations are useful when working in large clusters where you > need to move components around in the cluster (add 50 RegionServers on a set > of hosts, remove 50 RegionServers from a different set of hosts). > > > Diffs > ----- > > ambari-web/app/controllers/main/host/bulk_operations_controller.js b0ea13b > ambari-web/app/messages.js a12b729 > ambari-web/app/templates/main/host/bulk_operation_menu.hbs fab2576 > ambari-web/app/utils/ajax/ajax.js a5d0899 > ambari-web/app/views/main/host/hosts_table_menu_view.js 733edc7 > ambari-web/test/controllers/main/host/bulk_operations_controller_test.js > 05e0904 > > Diff: https://reviews.apache.org/r/44413/diff/ > > > Testing > ------- > > Added unit test. Local ambari-web test passed. > 24557 tests complete (21 seconds) > 146 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
