Hi Developers, AMBARI-19149 along with a few other Jiras have recently been checked-in allowing our builds to fail when we have checkstyle violations. Right now, we're using this framework to check for things like:
- private @Transactional methods - Switch statement fall-through - Import organization Although the first two will cause problems in the code, the 3rd might seem mostly superficial. However, it's been our experience that when cherry-picking in multiple branches, imports being out of order can cause lots of merge conflicts. It's a frustration point that we're hoping to resolve. All that you need to do is run your test targets (which, we're all doing for every patch, right :) ) and if there are problems it will fail the build locally. I've updated the wiki for the import style standards moving forward... Thanks, - Jonathan
