payert commented on a change in pull request #3243:
URL: https://github.com/apache/ambari/pull/3243#discussion_r504542584
##########
File path: ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js
##########
@@ -273,7 +273,7 @@ define([
}
var metricTransform = !target.transform || target.transform ===
"none" ? '' : '._' + target.transform;
var seriesAggregator = !target.seriesAggregator ||
target.seriesAggregator === "none" ? '' : '&seriesAggregateFunction=' +
target.seriesAggregator;
- var templatedComponent = (_.isEmpty(tComponent)) ? target.app :
tComponent;
+ var templatedComponent = (_.isEmpty(target.app)) ? tComponent :
target.app;
Review comment:
If the metric name is changed, please update it in the metrics_whitelist
files as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
