[GitHub] [ambari] akiyamaneko opened a new pull request #3266: [AMBARI-25592] Fix the problem that JVM related metrics in hbase and ams cannot be displayed

Wed, 25 Nov 2020 03:58:32 -0800 


akiyamaneko opened a new pull request #3266:
URL: https://github.com/apache/ambari/pull/3266


   ## What changes were proposed in this pull request?
   1. Fix jvm metrics of the ams-hbase and hbase compoments cannot be displayed
   2. Rename some widget name  in ams-hbase/hbase and introduced new G1GC 
related metrics, as shown below:
   
   | location                              | old title          | curren title  
                          |
   | ------------------------------------- | ------------------ | 
--------------------------------------- |
   | hbase-regionservers/JVM-GC COUNTS     | GC Count ParNew /s | GC 
Count(ParNew/G1 Young Generation) /s |
   | hbase-regionservers/JVM-GC TIMES      | GC Times ParNew /s | GC 
Times(ParNew/G1 Young Generation) /s |
   | ams-hbase-regionservers/JVM-GC COUNTS | GC Count ParNew /s | GC 
Count(ParNew/G1 Young Generation) /s |
   | hbase-regionservers/JVM-GC COUNTS     | GC Times ParNew /s | GC 
Times(ParNew/G1 Young Generation) /s |
   
   This modification mainly considers that HBase may now use G1GC or CMS. The 
previous widget names only covered CMS metrics. We not only renamed them, but 
also introduced the metricscorresponding to G1GC into the widget to ensure that 
both  G1GC and CMS can be displayed normally.
   
   ## How was this patch tested?
   
   manual tests work well as below:
   
   
   **hbase-regionservers_MEMORY**
   
![hbase-regionservers_MEMORY-fixed](https://user-images.githubusercontent.com/52202080/100224292-9c8bcd00-2f57-11eb-9b9f-64a0a778f25a.png)
   **hbase-regionservers_JVM-GC TIMES USED G1GC**
   ![hbase-regionservers_JVM-GC 
TIMES-fixed](https://user-images.githubusercontent.com/52202080/100224298-9e559080-2f57-11eb-940d-f4bf3f9115df.png)
   
   
   **ams-hbase-regionservers_JVM-GC TIMES USED CMS**
   ![ams-hbase-regionservers_JVM GC 
TIMES-fixed](https://user-images.githubusercontent.com/52202080/100224814-48cdb380-2f58-11eb-8c81-1143705e1804.png)
   
   
   **hbase-regionservers_JVM GC COUNTS USED G1GC**
   ![hbase-regionservers_JVM GC 
COUNTS-fixed](https://user-images.githubusercontent.com/52202080/100224302-9f86bd80-2f57-11eb-8a7e-045c2cf1bae4.png)
   
   **ams-hbase-regionservers_JVM GC COUNTS  USED CMS**
   ![Uploading ams-hbase-regionservers_JVM GC COUNTS-fixed.png…]()
   
   
   **hbase-home_REGIONSERVER MEMORY**
   ![hbase-home_REGIONSERVER 
MEMORY-fixed](https://user-images.githubusercontent.com/52202080/100224312-a1e91780-2f57-11eb-9101-b30744f94a0f.png)
   
   
   Please review [Ambari Contributing 
Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) 
before opening a pull request.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to