eubnara commented on code in PR #3354:
URL: https://github.com/apache/ambari/pull/3354#discussion_r961188105
##########
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AgentCommandsPublisher.java:
##########
@@ -111,7 +111,10 @@ public void sendAgentCommand(Multimap<Long, AgentCommand>
agentCommands) throws
if (!clusterDesiredConfigs.containsKey(clusterId)) {
clusterDesiredConfigs.put(clusterId,
clusters.getCluster(clusterId).getDesiredConfigs());
}
- } catch (NumberFormatException|AmbariException ignored) {}
+ } catch (NumberFormatException|AmbariException e) {
+ LOG.error("Exception on sendAgentCommand", e);
+ throw new AmbariRuntimeException(e);
Review Comment:
@brahmareddybattula
Hmm... Is it better not to rethrow? Just logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
