brahmareddybattula commented on PR #3366: URL: https://github.com/apache/ambari/pull/3366#issuecomment-1253151704
> > Please go through following committer guideliness, there are some more. > > https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit > > A committer must sign off on a patch. It is very helpful if the community also reviews the patch, but in the end a committer must take responsibility for the correctness of the patch. If the patch is simple enough and the committer feels confident in the review, a single +1 from a committer is sufficient to commit the patch. (Remember committers cannot review their own patch. If a committer submits a patch, they should make sure that another committer reviews it.) > > @brahmareddybattula Thanks for your suggestion and it makes sense. But this PR was completely ported from Bigtop Mpack and I've reviewed this PR and tested it based on Centos-7 (x86_64 and Arm64). I'd like to make up for it now. that doesn't mean, we should merge to ambari directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
