kevinw66 commented on code in PR #3381:
URL: https://github.com/apache/ambari/pull/3381#discussion_r993267213
##########
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py:
##########
@@ -242,6 +242,22 @@ def get_packages(scope, service_name = None,
component_name = None):
return packages
+def setup_stack_symlinks(version):
+ """
+ Invokes <stack-selector-tool> set all against a calculated fully-qualified,
"normalized" version based on a
+ stack version, such as "2.3". This should always be called after a component
has been
+ installed to ensure that all HDP pointers are correct. The stack upgrade
logic does not
+ interact with this since it's done via a custom command and will not trigger
this hook.
+ :return:
+ """
+ # get the packages which the stack-select tool should be used on
+ stack_packages = get_packages(PACKAGE_SCOPE_INSTALL)
+ if stack_packages is None:
+ return
+
+ # On parallel command execution this should be executed by a single
process at a time.
+ for package in stack_packages:
+ select(package, version)
Review Comment:
Please use the correct indent in comments
##########
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py:
##########
@@ -44,7 +44,8 @@
def _get_cmd(command, package, version):
conf_selector_path =
stack_tools.get_stack_tool_path(stack_tools.CONF_SELECTOR_NAME)
- return ('ambari-python-wrap', conf_selector_path, command, '--package',
package, '--stack-version', version, '--conf-version', '0')
+ # return ('ambari-python-wrap', conf_selector_path, command, '--package',
package, '--stack-version', version, '--conf-version', '0')
Review Comment:
We should delete the code rather than comment it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
