JiaLiangC commented on code in PR #3681:
URL: https://github.com/apache/ambari/pull/3681#discussion_r1192898809
##########
ambari-agent/conf/unix/agent-multiplier.py:
##########
@@ -226,7 +226,7 @@ def create_host_name_script(self, host_name,
host_name_script):
"echo HOSTNAME"
with open(str(host_name_script), "w+") as f:
f.writelines(template.replace("HOSTNAME", host_name))
- subprocess32.call("chmod +x %s" % host_name_script, shell=True)
+ subprocess.call("chmod +x %s" % host_name_script, shell=True)
Review Comment:
I agree with you that Python introduces true concurrency through the use of
multiple processes. However, Python 2 doesn't have the subprocess module by
default. Therefore, we copied the subprocess module from Python 3's standard
library and made compatibility modifications to maintain it within the Ambari
codebase. So, if we upgrade to Python 3, we won't need to maintain our own
version of the subprocess module anymore and can directly use the one provided
by Python 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
