smallyao commented on code in PR #3695:
URL: https://github.com/apache/ambari/pull/3695#discussion_r1200274120
##########
ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/SPARK/service_advisor.py:
##########
@@ -211,10 +204,10 @@ def recommendSPARK2ConfigurationsFromHDP26(self,
configurations, clusterData, se
if Spark2ServiceAdvisor.isKerberosEnabled(services, configurations):
- spark2_defaults = self.getServicesSiteProperties(services,
"spark2-defaults")
+ spark2_defaults = self.getServicesSiteProperties(services,
"spark-defaults")
Review Comment:
Should we rename this variable to spark-defaults?
##########
ambari-server/src/main/resources/stacks/BIGTOP/3.2.0/services/SPARK/service_advisor.py:
##########
@@ -189,18 +189,11 @@ def recommendSpark2ConfigurationsFromHDP25(self,
configurations, clusterData, se
:type services dict
:type hosts dict
"""
- putSparkProperty = self.putProperty(configurations, "spark2-defaults",
services)
- putSparkThriftSparkConf = self.putProperty(configurations,
"spark2-thrift-sparkconf", services)
-
- spark_queue = self.recommendYarnQueue(services, "spark2-defaults",
"spark.yarn.queue")
+ putSparkProperty = self.putProperty(configurations, "spark-defaults",
services)
+ spark_queue = self.recommendYarnQueue(services, "spark-defaults",
"spark.yarn.queue")
if spark_queue is not None:
putSparkProperty("spark.yarn.queue", spark_queue)
- spark_thrift_queue = self.recommendYarnQueue(services,
"spark2-thrift-sparkconf", "spark.yarn.queue")
- if spark_thrift_queue is not None:
- putSparkThriftSparkConf("spark.yarn.queue", spark_thrift_queue)
-
-
def recommendSPARK2ConfigurationsFromHDP26(self, configurations,
clusterData, services, hosts):
Review Comment:
The spark version in bigtop 3.2.0 is 3.2.3, would it be better if we change
"spark2" to "spark" in service advsior.py?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
