timyuer commented on code in PR #3646:
URL: https://github.com/apache/ambari/pull/3646#discussion_r1215290800
##########
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java:
##########
@@ -1743,15 +1743,22 @@ public boolean
checkStaleConfigsStatusForHostComponent(ServiceComponentHost sch,
String type = changedConfigType.getKey();
stale |= (serviceInfo.hasConfigDependency(type) ||
componentInfo.hasConfigType(type));
if (stale) {
- changedProperties.addAll(changedConfigType.getValue());
+ for (String propertyName : changedConfigType.getValue()) {
+ changedProperties.add(type + "/" + propertyName);
+ }
}
}
String refreshCommand =
calculateRefreshCommand(stackInfo.getRefreshCommandConfiguration(), sch,
changedProperties);
+ Map<String, HostConfig> actual = sch.getActualConfigs();
+
+ Map<String, Map<String, String>> desired =
getEffectiveDesiredTags(cluster, sch.getHostName(),cluster.getDesiredConfigs());
+
Review Comment:
Yeah, that's a great idea. But I found logs missing all the way down the
data link, not just this one. Maybe we should start a discussion to improve
Ambari's logging？
Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
