arshadmohammad commented on code in PR #3751:
URL: https://github.com/apache/ambari/pull/3751#discussion_r1405633056
##########
ambari-common/src/main/python/ambari_commons/repo_manager/yum_manager.py:
##########
@@ -352,7 +330,7 @@ def rpm_check_package_available(self, name):
regex = re.compile(name_regex)
for package in packages:
- if regex.match(package['name']):
+ if regex.match(package['name'].decode()):
Review Comment:
@wenwj0 seems you have not addressed this comment.
you can change the code with some thing like this:
` pkg_name = package['name'].decode() if isinstance(package['name'], bytes)
else package['name']
if regex.match(pkg_name):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
