zRains commented on PR #3914: URL: https://github.com/apache/ambari/pull/3914#issuecomment-2547543306
> After running npm i these files are being added in .gitignore automatically. @sandeep318kumar I removed these lines from the .gitignore file and ran `npm i` again, but the file wasn’t added automatically. Here’s my development environment: ```text OS: Ubuntu Jammy 22.04 x86_64 Kernel: Linux 5.15.0-126-generic Shell: bash 5.1.16 CPU: 4 x AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (4) @ 3.79 GHz Node: v20.18.1 PackageManager: pnpm@9.15.0 ``` IMO, `tsconfig.node.json` shouldn’t be ignored, as this might lead to inconsistencies in each developer's working environment, potentially causing unexpected issues down the line. I checked this part of the code using `git blame` and found that it was committed by @vanshuhassija. Perhaps they have a different perspective? https://github.com/apache/ambari/commit/66f6803d200423b179b4412638e58f4c47ba0f94#diff-999547fd46d36ec2ad1d5c872332f2abdacc1b0cb06773066470a278ae92686eR26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
