nikita15p commented on PR #4030: URL: https://github.com/apache/ambari/pull/4030#issuecomment-3092524184
@himanshumaurya09876 Great work on the PR! I wanted to highlight an observation regarding timezone handling between EmberJS and ReactJS. Currently, EmberJS uses `moment-timezone` for timezone handling, and the `timezoneUtils` module relies heavily on `moment.tz` for parsing, formatting, and detecting timezones. On the other hand, ReactJS imports `detectUserTimezone` and `parseTimezones` from the `timezone` module. I noticed that the data persisted from EmberJS does not get parsed correctly into ReactJS and vice versa. For example: - In EmberJS, selecting `(UTC-06:00 UTC) Pacific / Galapagos` sets `"admin-settings-timezone-admin":"\"-360-360|Pacific\""` - In ReactJS, the same timezone is represented as `"admin-settings-timezone-admin":"\"360360|Pacific\""` This discrepancy can lead to inconsistencies during migration or integration between the two frameworks. To ensure seamless compatibility, I suggest defining a unified format for timezone data that works across both frameworks. @zRains do you think standardizing the timezone format and mapping logic would be the best way forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org For additional commands, e-mail: dev-h...@ambari.apache.org
