eubnara commented on code in PR #4043:
URL: https://github.com/apache/ambari/pull/4043#discussion_r2247254713
##########
ambari-server/src/main/resources/stacks/BIGTOP/3.3.0/services/RANGER/package/scripts/setup_ranger_xml.py:
##########
@@ -465,24 +465,43 @@ def password_validation(password):
def copy_jdbc_connector(ranger_home):
import params
- if params.jdbc_jar_name is None and
params.driver_curl_source.endswith("/None"):
+ if params.jdbc_jar_name is None or
params.driver_curl_source.endswith("/None"):
Review Comment:
If `jdbc_jar_name` is `None`, `driver_curl_source` ends with `/None` because
`driver_curl_source = format("{jdk_location}/{jdbc_jar_name}")` at params.py.
Either `jdbc_jar_name` or `driver_curl_source` is not appropriate, it is
reasonable to raise Fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ambari.apache.org
For additional commands, e-mail: dev-h...@ambari.apache.org
