dilrajsourabh commented on PR #4116: URL: https://github.com/apache/ambari/pull/4116#issuecomment-5384231019
Hi @maxatwork ,thanks for the clarification, and for checking the codebase. You're right — form2js was only listed in bower.json and imported in ember-cli-build.js, with no actual usage anywhere in the WF Manager UI. I've updated the PR accordingly: - Removed the form2js dependency from bower.json - Removed the unused import from ember-cli-build.js This should fully address the build failure without depending on the upstream repo at all. The change is pushed in commit 8c31f68c70. Could you please merge this when you get a chance? Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
