prabhjyotsingh commented on code in PR #4261:
URL: https://github.com/apache/ambari/pull/4261#discussion_r4630614229
##########
ambari-web/latest/src/hooks/useEnhancedConfigs.ts:
##########
@@ -689,6 +710,21 @@ function useEnhancedConfigs(
}
if (shouldIncludeProperty && allowUpdateProperty(propertyName,
configType + ".xml", "Default", null, null)) {
+ // Like Ember's _createNewProperty: a recommended property the
stack does not
+ // define (e.g. hadoop.proxyuser.*) must join the configs, or it
is never deployed.
+ if (
+ targetServiceName
+ && targetServiceName !== "MISC"
+ && !deletedProperties.has(`${propertyName}_${configType}`)
+ ) {
+ addRecommendedConfigProperty(
+ configProperties,
+ targetServiceName,
+ configType,
+ propertyName,
+ recommendedValue,
+ );
+ }
Review Comment:
Thanks for catching this, you're right. createConfiguration in
AmbariManagementControllerImpl builds the new config version from exactly the
properties in the request and doesn't merge with the existing desired config. A
payload containing only hadoop.proxyuser.hive.hosts would have dropped
fs.defaultFS and every other core-site key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]