Hi
Thanks for starting this discussion.
+1 to do this before the first Apache release. IMHO, sooner or later
after entering the Apache Foundation, we'll need to do a rename for these
classes, so doing it before releasing the first Apache version will have
the least impact.
we need to describe in detail how to upgrade from a previous version
in the release note and the documentation so that people can upgrade from
the Non-Apache release easily.
Best,
Congxian
Jinsong Zhou <jinsongz...@apache.org> 于2024年5月7日周二 19:51写道：
> Hi,
>
> Thanks for starting this discussion.
> I agree that the names of classes need to be renamed, but we have
> to specify the effects of the renaming:
> The tables created in the old version can still work but users need to
> upgrade both the AMS and the Spark/Flink runtime jars at the same time
> otherwise, compatibility issues may arise.
>
> I think it is accepted because 0.7.0 will be a big change version. 0.7.0 is
> the first version of Amoro after entering the ASF incubator, and it's also
> a version with significant changes.
> However, I still want to hear more input from more developers and users.
>
> Best,
> Jinsong
>
>
> On Mon, May 6, 2024 at 9:20 PM Qishang Zhong <zhongqish...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > I would like to start a discussion on PR[1] before amoro releases the
> first
> > apache version.
> >
> > Two things are clear :
> > 1. We need to rename
> > 2. Modify it before releasing apache release to reduce the impact of
> > subsequent modifications.
> >
> > Concern from zhoujinsong
> > > It may cause some problems when users try to upgrade to the new
> version.
> >
> > We need to make it clear in the upgrade documentation that the Thrift API
> > is not forward compatible.
> >
> > I'm looking forward to your thoughts.
> >
> > [1]: https://github.com/apache/amoro/pull/2801
> >
> > Best Regards,
> > Qishang Zhong
> >
>
