-1 (binding) Source code compilation failed[1]. The source code does not contain a .git folder, causing git-commit-id-plugin to occur an error.
[1]:https://github.com/apache/amoro/issues/3041 Best, Qishang Congxian Qiu <qcx978132...@gmail.com> 于2024年7月16日周二 10:19写道： > Hi > Found that there are still some "arctic" in the source code, do we need > to rename them all to amoro in this release? > some result from execute `grep arctic -r $sourceDir` > > ``` > > ./amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java: > return "arctic"; > > ./amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java: > return "arctic"; > > ./amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/SparkContextUtil.java: > if ("arctic".equalsIgnoreCase(connector)) { > > ./amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/model/SqlExample.java: > + ") using arctic \n" > > ./amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/dashboard/model/TableMeta.java: > ARCTIC("arctic"), > ``` > Best, > Congxian > > > Paul Lam <paullin3...@gmail.com> 于2024年7月15日周一 18:02写道： > > > +1 (non-binding) > > > > - built from source with hadoop3 > > - checked LICENSE/NOTICE files > > > > Best, > > Paul Lam > > > > > 2024年7月12日 15:58，Jinsong Zhou <jinsongz...@apache.org> 写道： > > > > > > Hello Amoro devs, > > > > > > Kindly request the devs review and vote for releasing Amoro > > > 0.7.0-incubating. > > > > > > Apache Amoro(incubating) is a Lakehouse management system built on open > > > data lake formats. > > > > > > The official Apache source release to be deployed to dist.apache.org: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/amoro/0.7.0-incubating-RC1/ > > > > > > This source release has been signed with a PGP available here (Apache > ID: > > > jinsongzhou): > > > > > > https://downloads.apache.org/incubator/amoro/KEYS > > > > > > All artifacts to be deployed to the Maven Central Repository: > > > https://repository.apache.org/content/repositories/orgapacheamoro-1032 > > > https://repository.apache.org/content/repositories/orgapacheamoro-1063 > > > > > > > > > Git branch for the release: > > > > > > https://github.com/apache/amoro/tree/v0.7.0-rc1 > > > https://github.com/apache/amoro-shade/tree/v0.7.0-rc1 > > > > > > Please download, verify, and test. > > > > > > The VOTE will pass after 3 binding approve. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about Apache Amoro, please see https://amoro.apache.org/ > > > <https://paimon.apache.org/> > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] All source files have ASF headers > > > [ ] Can compile from source > > > > > > Best, > > > Jingsong > > > > >
