Hi, +1 for supporting configuring the number of remaining snapshots.
Besides, we may need to refactor the configuration name to: * snapshot.keep.min-count = 10 * snapshot.keep.duration = 7d Base is a concept of Mixed format, we should not keep it in the common configuration names. There is some other issue[1] focusing on improving configuration value with duration unit. [1] https://github.com/apache/amoro/issues/3119 Best, Jinsong On Mon, Sep 2, 2024 at 6:02 PM Paul Lam <paullin3...@gmail.com> wrote: > +1 for supporting the snapshots to keep. > > However, Iceberg natively supports `history.expire.min-snapshots-to-keep`, > should we directly reuse its value? > > Best, > Paul Lam > > > 2024年9月2日 16:10，Xavier Bai <x...@apache.org> 写道： > > > > Hi developers, > > > > Currently, when we execute expired snapshots, we only consider the TTL > as a > > factor. However, Iceberg supports setting a minimum number of snapshots > to > > retain. I believe we should also make this configuration option > > available(eg. `snapshot.base.keep.min-count`). For developers and table > > users, these snapshots can be understood as the update logs of the table, > > making it easier for users to review the history of updates. If there are > > no updates for an extended period, Amoro may only retain a single > snapshot > > after cleanup, which could result in a loss of information for users. > > > > In addition, the Iceberg community is also working on retaining more > > historical snapshot information in an additional folder. I believe this > is > > a significant requirement > > > > Best regards, > > Xu Bai > >
