tilgovi commented on pull request #87: URL: https://github.com/apache/incubator-annotator/pull/87#issuecomment-681312139
I'll take another look at `makeRefinable` and test out how it behaves when called from TypeScript on different inputs. I also think it may be okay to add back the `Matcher` parametrized type, but might avoid aliasing it with filled in parameters to avoid the relative path lint issues _for now_. I do want to solve that code organization question, though, and I think we could eventually add `DomMatcher` back in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
